Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[NumberBox, fix proposed] Initially collapsed number boxes will never show spin buttons

See original GitHub issue

Describe the bug

NumberBox that was created in Collapsed state and then made Visible - will never show spin buttons. For example, for Page that adapts to window size it could be useful to create two NumberBox, visible and invisible, bound to the same property, and do something like this:

<VisualState.StateTriggers>
    <AdaptiveTrigger MinWindowWidth="{StaticResource MinWindowSnapPoint}" />
</VisualState.StateTriggers>
<VisualState.Setters>
    <Setter Target="RightPane.Visibility" Value="Collapsed"/>
    <Setter Target="BottomPane.Visibility" Value="Visible"/>
</VisualState.Setters>

it’s enough to provoke bug.

Steps to reproduce the bug

New C++ Blank project, add to MainPage.xaml such code:

    <StackPanel Spacing="8">
        <CheckBox x:Name="checkBox" Content="Show NumberBox" IsChecked="True"/>
        <muxc:NumberBox SpinButtonPlacementMode="Inline" Value="123" Header="This NumberBox was Visible initial part of lifetime, buttons are here" Visibility="{Binding IsChecked, ElementName=checkBox}"/>
        <muxc:NumberBox SpinButtonPlacementMode="Inline" Value="456" Header="This NumberBox was Collapsed initial part of lifetime, buttons are lost" Visibility="{Binding IsChecked, ElementName=checkBox, FallbackValue=Collapsed}"/>
    </StackPanel>

Expected behavior

Both NumberBox-es should have spin buttons

Screenshots

NuGet package version

Microsoft.UI.Xaml 2.7.0

Windows app type

UWP
Win32

Device form factor

No response

Windows version

Insider Build (xxxxx)

Additional context

Windows 11.0.22000, WinUI 2.7

Issue Analytics

State:
Created 2 years ago
Comments:6 (6 by maintainers)

Top GitHub Comments

1reaction

eugenegffcommented, Oct 7, 2021

The reason is obvious - NumberBox::UpdateSpinButtonPlacement() is not called in NumberBox::OnApplyTemplate(), and for initially collapsed NumberBox template is applied very late, only when NumberBox became visible. Will prepare pull request with the fix.

0reactions

msftbot[bot]commented, Jan 3, 2023

🎉This issue was addressed in #6053, which has now been successfully released as Microsoft.UI.Xaml v2.8.2.🎉

Handy links: