question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Proposal: Rename MUX.Media.Animation.Storyboard.GetCurrentTime

See original GitHub issue

Proposal: Rename Storyborard.GetCurrentTime

Summary

The Microsoft.UI.Xaml.Media.Animation.Storyboard.GetCurrentTime method creates problems (a warning) when using from C++/WinRT:

1>F:\win32\Debug\Generated Files\winrt\impl\Windows.UI.Xaml.Media.Animation.0.h(2306,39): warning C4002: too many arguments for function-like macro invocation 'GetCurrentTime'

This is because Windows.h has a macro for GetCurrentTime. One can work around this by #undef GetCurrentTime before including xaml headers, this isn’t ideal nor intuitive for first-time users of the platform.

Rationale

A project should build cleanly without warnings on the first try.

Open Questions

What should the new name be?

  • GetCurrentTimestamp
  • GetCurrentStoryboardTime
  • ?

Issue Analytics

  • State:open
  • Created 2 years ago
  • Reactions:5
  • Comments:8 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
asklarcommented, Aug 26, 2021

Never a better time to make a breaking change than before 1.0 GA 😃 @codendone fyi

0reactions
sylveoncommented, Aug 27, 2021

It could be an inline function instead of a macro, but getting the function renamed in WinUI is much easier and will take less time than changing the Windows SDK.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Storyboard Class (Windows.UI.Xaml.Media.Animation)
Returns any base value established for a dependency property, which would apply in cases where an animation is not active. (Inherited from DependencyObject)....
Read more >
How to Rename Panels in Storyboard Pro - YouTube
http://learn.toonboom.com/modules/panels/topic/ renaming -panels You can rename panels one at a time using the Panel view or rename multiple ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found