question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Proposal: Round(ed) Button

See original GitHub issue

Proposal: Round(ed) Button

Summary

image

This would be a button which overrides it’s CornerRadius value to always create a rounded “pill” like appearance

Rationale

  • Based on Button, except the CornerRadius is determined to always be half the height of the button as rendered
  • Minimum width matches the height making the Button appear as a circle. (like an Icon only Button for instance)

Scope

Capability Priority
CornerRadius is handled by the control, and not discreetly Must
Include Accent and Subtle style variants Should
RepeatButton and ToggleButton variants Could
There could be scope for DropDown and SplitButton variants Could

Important Notes

As content changes for buttons, if text is wrapped or font sizes changed, just using styles or CornerRadius values will not work, so this is why I am proposing something more than just including styles.

image

Open Questions

Could this perhaps be added as a property on the ButtonBase control when the source is opened, to remove the need to duplicate or derive these controls?

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:13
  • Comments:8 (3 by maintainers)

github_iconTop GitHub Comments

4reactions
huoyaoyuancommented, Jan 27, 2021

Could this perhaps be added as a property on the ButtonBase control when the source is opened, to remove the need to duplicate or derive these controls?

It definitely should. Creating new control for this is opposed to the spirit of xaml that don’t create new controls for duplicated functionality with just styling.

just using styles or CornerRadius values will not work

Styling system should be improved to make that possible.

1reaction
SeanLedbettercommented, Jan 30, 2021

Overly rounded buttons seem like a bad design choice to me. Right now, Google has them all over the place. I wouldn’t say Google is the best at design. I don’t know why overly rounded buttons seem so out of place… maybe it’s because they are not form fitting to the content area or the squared screen they are displayed on. Also, it reminds me of the pill toggle when Windows 10 first came out. Does anyone remember the pill toggle? I had almost forgotten. windows-10-turn-off-window-animations

Read more comments on GitHub >

github_iconTop Results From Across the Web

The Proposal 2 Inch Round Button
Button pins that really stand out with thousands of designs to pick from. Create easy make buttons & pins today!
Read more >
Rounded or Sharp-Corner Buttons?
Trivial Design Decisions That Actually Matter ... Rounded-corner buttons or sharp-corner buttons? Circular logo or triangular logo? Arial or Helvetica Neue? Does ...
Read more >
Round Button
Round Button. Inspirational designs, illustrations, and graphic elements from the world's best designers. Want more inspiration? Browse our search results.
Read more >
How To Round The Corners Of Buttons In HighLevel Funnel ...
How To Round The Corners Of Buttons In HighLevel Funnel Builder ... How to Automate Proposal or Contract Sending with Pandadoc inside Go ......
Read more >
17 Best Practices for Crazy-Effective Call-To-Action Buttons
You'll need to consider whether you want to go with a more rounded button shape or a button with square edges. Hard to...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found