question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Unreachable code in `AnimatedIcon`

See original GitHub issue

Describe the bug

While porting the AnimatedIcon source code, I noticed that the UpdateMirrorTransform() call cannot be reached by any possible path:

https://github.com/microsoft/microsoft-ui-xaml/blob/ba55e86fab216886a10b0b248c931e11a4e0a64f/dev/AnimatedIcon/AnimatedIcon.cpp#L543-L554

Should it be moved above or removed?

Steps to reproduce the bug

See code

Expected behavior

Should be reachable.

Screenshots

N/A

Version Info

main

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
MartinZikmundcommented, Jun 25, 2021

@chingucoding yes, I noticed it thanks to IntelliSense underlining it 😀

0reactions
MartinZikmundcommented, Jun 30, 2021

@StephenLPeters happy to do it! Just remove the call or move it before the returns? Just checking whether it was there by intention or not

Read more comments on GitHub >

github_iconTop Results From Across the Web

Flutter: Creating an add_close AnimatedIcons
@mFeinstein I'd like to create a beginning icon as Icon.add and end icon of Icon.close in the AnimatedIcon widget. For e.g. their is...
Read more >
Exploring 'AnimatedIcon' in Flutter | by Usman Khan
AnimatedIcon is a widget provided by Flutter SDK which animates the switching of an icon with other. The seamless transition of switching ...
Read more >
How to use AnimatedIcon widget in Flutter
This code snippet will play the animation when the user taps the widget and pause it when tapped again. Dispose of resources. Don't...
Read more >
AnimatedIcon Class (Microsoft.UI.Xaml.Controls)
Represents an icon that displays and controls a visual that can animate in response to user interaction and visual state changes.
Read more >
Create an Animated Icon to Scroll To Section with Lottie ...
brizy #brizycloud #learnbrizy #websitebuilder #pagebuilder #lottiefiles #elementanimation In this video, I'll show you how to create an ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found