[Bug] lazily adding extra libs did not trigger re-validation of semantic

Reproducible in vscode.dev or in VS Code Desktop?

• Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

• Not reproducible in the monaco editor playground

Monaco Editor Playground Code

monaco.languages.typescript.typescriptDefaults.setDiagnosticsOptions({
    // I don't want to disable semantic validation.
	noSemanticValidation: false,
	noSyntaxValidation: false
});

function addLib() {
    console.log('adding lib...');
    // extra libraries
    var libSource = [
        'declare class Facts {',
        '    /**',
        '     * Returns the next fact',
        '     */',
        '    static next():string',
        '}'
    ].join('\n');
    var libUri = 'ts:filename/facts.d.ts';
    monaco.languages.typescript.typescriptDefaults.addExtraLib(libSource, libUri);
    monaco.editor.createModel(libSource, 'typescript', monaco.Uri.parse(libUri));
}

var jsCode = [
	'"use strict";',
	'',
	'class Chuck {',
	'    greet() {',
	'        return Facts.next();',
	'    }',
	'}'
].join('\n');

monaco.editor.create(document.getElementById('container'), {
	value: jsCode,
	language: 'typescript'
});

// `setEagerModelSync` would not help here.
// monaco.languages.typescript.typescriptDefaults.setEagerModelSync(true);

// Simulate adding libs lazily.
setTimeout(addLib, 2000);
// Changing timeout to `0` will make it work.

Actual Behavior

It shows Cannot find name 'Facts' while it shows class Facts above which indicates the lib has been loaded.

And when I make any edits, the error disappears.

I tried add monaco.languages.typescript.typescriptDefaults.setEagerModelSync(true) but it didn’t help.

I think a re-validation of semantic should be done automatically after adding libs. Or Monaco should expose an API to do this.

Expected Behavior

Expect the error message disappears after libs loaded.

Additional Context

No response

[hediet]

Could you please fix npm publish job so that we could test the change asap?

Done.

Repo owners?

Yes

[mifopen]

@alexdima Could you provide your estimates on this? Or maybe any workarounds? We’re heavily relying on this and can’t downgrade as several other bugs were resolved in the new version.