Monaco TypeScript master broken in amd build?

monaco-editor version: 2a99615 Browser: N/A OS: N/A Playground code that reproduces the issue: I don’t think its set up to run on commits

The TS site builds a nightly version of both Monaco Editor and Monaco TS here

The build yesterday broke at runtime in what I think is monaco-typescript code:

• Two days ago: 🟢 https://www.typescriptlang.org/play?ts=4.1.0-dev.20200906#code/MYewdgzgLgBAFgUwDZJDAvDARAdxAJyQBMsAoIA
• One day ago: 🟢 https://www.typescriptlang.org/play?ts=4.1.0-dev.20200907#code/MYewdgzgLgBAFgUwDZJDAvDARAdxAJyQBMsAoIA
• This morning: 🔴 https://www.typescriptlang.org/play?ts=4.1.0-dev.20200908#code/MYewdgzgLgBAFgUwDZJDAvDARAdxAJyQBMsAoIA

The raised issue is n.Emitter is not a constructor and when you go back in the trace it is requiring monaco.contribution.ts where it fails, likely here:

private _onDidChange = new Emitter<void>();
private _onDidExtraLibsChange = new Emitter<void>();

Maybe https://github.com/microsoft/monaco-typescript/commit/ee95401a407e42e1044813087ba6dc621ecc25e9 ?

( Left notes because I’m about go to hit meetings for the day )

[orta]

Confirmed that the above PR fixes it 👍🏻

[orta]

Cool, yeah, the TS site uses the release versions- I think it was that the change to add the dep wasn’t applied to all the parts in an amd release build. See #2118