[BUG] A png screenshot is produced when a jpeg/jpg screenshot is requested

Context:

• Playwright Version: 1.4.2 and 1.5.1
• Operating System: macOS, Linux
• Node.js version: 14.1.0
• Browser: All
• Extra: (None)

Code Snippet

(async () => {
  for (const browserType of ['chromium', 'firefox', 'webkit']) {
    const browser = await playwright[browserType].launch();
    const context = await browser.newContext();
    const page = await context.newPage();
    await page.goto('http://whatsmyuseragent.org/');
    //await page.screenshot({ path: `example-${browserType}.png` }); //Generates .png screenshots
    await page.screenshot({ path: `example-${browserType}.png`, type: "jpeg" }); //Also generates .png screenshots
    await browser.close();
  }
})();

Describe the bug

Providing type: "jpeg" in page.screenshot()'s options parameter has no effect. I initially noticed this problem on 1.4.2. After upgrading to 1.5.1, I’m still seeing the same behavior. All generated screenshots are of type png.

Documentation reference for page.screenshot() options

[arjunattam]

Thanks for confirming. I believe there are 2 action items:

1. Clarify in docs that extension in path takes precedence over type.
2. Support case where path does not have an extension, but type is specified.

[dave-cheever]

Hi Rich!

Thanks for the reply, although I figured it out with trial and error. Thank you so much for taking time to reply. And I’ll create a separate ticket if I encounter a problem.

Thanks!

On Tue, Jan 12, 2021 at 12:58 AM Rich Christiansen [e-mail] wrote:

Hi, @dave-cheever https://github.com/dave-cheever! You can use an absolute path (/tmp/filename.png) or a relative path ( …/example/filename.png).

In the future, instead of commenting on an irrelevant Issue, please create a new Issue or Discussion.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/microsoft/playwright/issues/4238#issuecomment-758085965, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACSLDW2TRZWDPB7TEQ5EF43SZMU2JANCNFSM4S7U7NJA .