[BUG] Proxying WebSockets with http-proxy not working with firefox and webkit

Context:

• Playwright Version: [^0.11.1]
• Operating System: [Windows 10]
• Extra: [Using docker to launch playwright server ]

Code Snippet

playwright-docker-server

Describe the bug

I am trying to dockerized the playwright to launch a server inside the docker and proxy the socket as follow:

import * as httpProxy from 'http-proxy';
import * as playwright from 'playwright';

const proxy = httpProxy.createProxyServer();
http
  .createServer()
  .on('upgrade', async (req, socket, head) => {
    const browser = await playwright['chromium'].launchServer({
      args: ['--no-sandbox'],
    });
    const endPoint = browser.wsEndpoint();
    proxy.ws(req, socket, head, {target: endPoint });
  })
  .on('listening', () => {
    console.log('Server listening...');
  })
  .on('close', () => {
    console.log('http server closed');
  })
  .listen(3000);

The above code works well with chrome, however, it won’t work with WebKit and firefox.

It throws following error for firefox:

(node:25528) UnhandledPromiseRejectionWarning: Error: WebSocket error: Unexpected server response: 400
    at WebSocket._ws.addEventListener.event (\node_modules\playwright-core\lib\platform.js:288:65)
    at WebSocket.onError (\node_modules\playwright-core\node_modules\ws\lib\event-target.js:128:16)
    at WebSocket.emit (events.js:194:15)
    at abortHandshake (\node_modules\playwright-core\node_modules\ws\lib\websocket.js:718:15)
    at ClientRequest.req.on (\node_modules\playwright-core\node_modules\ws\lib\websocket.js:595:7)
    at ClientRequest.emit (events.js:189:13)
    at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:556:21)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:109:17)
    at Socket.socketOnData (_http_client.js:442:20)
    at Socket.emit (events.js:189:13)
(node:25528) UnhandledPromiseRejectionWarning: Error: Protocol error (Target.enable): Target closed.
    at Promise (\node_modules\playwright-core\lib\firefox\ffConnection.js:54:63)
    at new Promise (<anonymous>)
    at FFConnection.send (\node_modules\playwright-core\lib\firefox\ffConnection.js:53:16)
    at Function.connect (\node_modules\playwright-core\lib\firefox\ffBrowser.js:49:26)
    at Firefox.connect (\node_modules\playwright-core\lib\server\firefox.js:132:38)
    at \src\main.ts:5:49
    at Generator.next (<anonymous>)
    at \node_modules\tslib\tslib.js:110:75
    at new Promise (<anonymous>)
    at Object.__awaiter (\node_modules\tslib\tslib.js:106:16)

And following error for WebKit:

 UnhandledPromiseRejectionWarning: Error: Protocol error (Browser.createContext): Browser has been closed.
    at Promise (\node_modules\playwright-core\lib\webkit\wkConnection.js:99:63)
    at new Promise (<anonymous>)
    at WKSession.send (\node_modules\playwright-core\lib\webkit\wkConnection.js:98:16)
    at WKBrowser.newContext (\node_modules\playwright-core\lib\webkit\wkBrowser.js:57:65)
    at WKBrowser.<anonymous> (\node_modules\playwright-core\lib\helper.js:55:31)
    at \src\main.ts:9:33
    at Generator.next (<anonymous>)
    at fulfilled (\node_modules\tslib\tslib.js:107:62)
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at Function.Module.runMain (internal/modules/cjs/loader.js:757:11)
  -- ASYNC --
    at WKBrowser.<anonymous> (\node_modules\playwright-core\lib\helper.js:54:23)
    at \src\main.ts:9:33
    at Generator.next (<anonymous>)
    at fulfilled (\node_modules\tslib\tslib.js:107:62)
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at Function.Module.runMain (internal/modules/cjs/loader.js:757:11)
    at startup (internal/bootstrap/node.js:283:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:622:3)

Not sure if this problem is related to #810, feel free to close this issue if it’s same.

[arjunattam]

Thanks @cyrus-d for reporting this. This implies that the system dependencies for the browsers are not installed in the docker image. To debug this, you can use dumpio: true in the launch() method arguments.

On looking at the dockerfile in playwright-docker-server repo, I can see some missing dependencies. You can refer to this working image for Ubuntu 18.04.

We are working on fixing the troubleshooting docs, and adding working dockerfile definitions

[ccpu]

@arjun27 thanks for the dockerfile it has solved my problem.