[BUG] Tracing does not seem to work with `electron` support

Context:

• Playwright Version: 1.20.1
• Operating System: macOS
• Node.js version: 16.x
• Browser: Electron

Code Snippet

Help us help you! Put down a short code snippet that illustrates your bug and that we can run and debug locally. For example:

const { _electron: electron } = require('playwright');

(async () => {

    // Launch Electron app.
    const electronApp = await electron.launch({ args: ['main.js'] });

    // Evaluation expression in the Electron context.
    const appPath = await electronApp.evaluate(async ({ app }) => {
        // This runs in the main Electron process, parameter here is always
        // the result of the require('electron') in the main app script.
        return app.getAppPath();
    });
    console.log(appPath);

    // Get the first window that the app opens, wait if necessary.
    const window = await electronApp.firstWindow();

    await window.context().tracing.start({ name: 'ETracing', screenshots: true, snapshots: true });

    // Print the title.
    console.log(await window.title());

    await new Promise(resolve => {
        setTimeout(() => {
            resolve();
        }, 10000);
    });

    await window.context().tracing.stop({ path: '/Users/bpasero/Desktop/elec-playwright/trace.zip' });


    // Direct Electron console to Node terminal.
    window.on('console', console.log);
    // Click button.
    await window.click('text=Click me');
    // Exit app.
    await electronApp.close();
})();

Describe the bug

I start Electron and the window opens and I start to click around and the trace is created after 10 seconds, but it contains no screenshots.

Attaching the trace for reference:

trace.zip

[bpasero]

I was able to revive my old branch and clean it up with latest and also verified that tracing does work (so I am fine closing this issue).

PR is up at https://github.com/microsoft/vscode/pull/146692 to verify the changes, so far I have not seen flakiness (did a test run of 7 across our platforms) 🤞 🤞

Let’s allocate some time and hack something together, it could be cool!

Happy to share our use of playwright in a meeting and get some feedback if we can improve things 👍

[pavelfeldman]

Understood, wouldn’t the Electron team itself be the best candidate for this? I am not sure if they already have smoke tests in place but it might be worthwhile reaching out to them.

I’d prefer to have someone with a real Electron app to test.

As for VSCode I cannot make promises, I had started a prototype a while ago but then was hitting a road block that now seems fixed, but my branch is horribly out of date and almost needs a rewrite…

Let’s allocate some time and hack something together, it could be cool!