question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[BUG] Unable change snapshot naming for webkit

See original GitHub issue

Context:

  • Playwright Version: 1.22
  • Operating System: linux ‘docker’
  • Node.js version: 14.6
  • Browser: webkit

Code Snippet

test.describe('Landing page Test Suite', () => {

    test.beforeEach(async ({ page, landingPage },testinfo) => {
        testinfo.snapshotSuffix = ''
        await page.goto(path.en.landingPage, { waitUntil: "load", timeout: 30000 })
    });

    test('Landing page is loading properly with all exact contents in EN lang', async ({ browserName, page }) => {
        expect(await page.screenshot({ fullPage: true, timeout: 4000 })).toMatchSnapshot(`${browserName}-EN.png`,{maxDiffPixels: 30,});
    });

Describe the bug

Test is failing in beforeEach hook for webkit when using testinfo.snapshotSuffix = ‘’

Screenshot 2022-05-17 at 23 46 48

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:8 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
rwollcommented, May 19, 2022

Repro for Bisect: https://github.com/rwoll/playwright-repro-14236 Bad Commit: 41db08eca567098857d574e06691b3b43e7d6afd: feat(webkit): roll to r1631 (https://github.com/microsoft/playwright/pull/13612) WebKit roll: https://github.com/microsoft/playwright/commit/d44cfb93cb66b21ba1df1f758a2f629530cac7c2 Environment: Docker container running on an M1 Mac

Since it’s a WK roll, looks like we’ll need to bisect WK itself. (NB: I also manually rolled ToT (432c52d31aaeeb279f4bd8b59de70a15ad1cab07) to r1647, and tested; it’s still failing on that revision.)

cc: @aslushnikov @mxschmitt @yury-s

1reaction
amrsa1commented, May 19, 2022

Thanks @amrsa1! It looks like I’ve found a standalone repro: https://github.com/rwoll/playwright-repro-14236

The error message is not identical, but it’s also WK+Linux/Docker-only fail. (My gut says they are related.)

Yes seems so, also extra info Im using macOs m1, running test inside docker container with param platform:linux/amd64 otherwise it wont work

Read more comments on GitHub >

github_iconTop Results From Across the Web

Full Text Bug Listing - WebKit Bugzilla
Summary: Web Inspector: [Chromium] Add an ability to show the objects that were allocated between snapshot N-2 and snapshot N-1 and still alive...
Read more >
How do I name my snapshots to best avoid errors? - IBM
I want to know the best practices for naming snapshots within a Process application or toolkit. I would like to be able to...
Read more >
Heap snapshots cannot be compared after saving and reloading
What went wrong? You are unable to compare two heap snapshots after reloading them into Chrome from files. This removes the utility of...
Read more >
Safari Technology Preview Release Notes - Apple Developer
commitStyles() not changing the style attribute for individual CSS transform ... Added an error message if unable to fetch shader source in the...
Read more >
Bug listing with status RESOLVED with resolution TEST ...
Bug :233 - "Emacs segfaults when merged through the sandbox. ... can't find module named docutils.core" status:RESOLVED resolution:TEST-REQUEST severity: ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found