Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
[BUG][Electron] filechooser event not emitted when dialog.show(Open|Save)Dialog is called
See original GitHub issueContext:
- Playwright Version: playwright-electron 0.5.0
- Operating System: Windows 10 20H2
- Node.js version: 12.18.1
- Browser: Electron 11.1.1
Description
The filechooser event is not emitted when dialog.show(Open|Save)Dialog is called in Electron’s main process. It doesn’t matter if the dialog function is called via app.evaluate during a test or triggered from the webapp. Electron also allows selecting directories by these dialogs, FileChooser should support this too.
Code Snippet
The following test suite that times out shows the issue. Adapted from How to demo on the npm package page, only spec.js is different. Put all three files in one dir and run npx mocha spec.js:
main.js:
const { app, BrowserWindow } = require('electron');
function createWindow () {
let win = new BrowserWindow({
width: 800,
height: 600,
});
win.loadFile('index.html');
}
app.whenReady().then(createWindow);
index.html:
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<title>Hello World!</title>
<meta http-equiv="Content-Security-Policy" content="script-src 'self' 'unsafe-inline';" />
<style>
html {
width: 100%;
height: 100%;
display: flex;
background: white;
}
body {
flex: auto;
display: flex;
justify-content: center;
align-items: center;
flex-direction: column;
}
</style>
</head>
<body>
<h1>Hello World!</h1>
<button onclick="console.log('click')">Click me</button>
</body>
</html>
spec.js:
const { electron } = require('playwright-electron');
const assert = require('assert');
const electronPath = require('electron');
const path = require('path');
describe('filechooser bug', function () {
this.timeout(10000);
before(async () => {
this.app = await electron.launch(electronPath, {
args: [path.join(__dirname, "main.js")]
});
});
after(async () => {
await this.app.close();
});
it('filechooser fires in electron', async () => {
let resolve;
const promise = new Promise(r => {
resolve = r;
});
const page = await this.app.firstWindow();
page.on('filechooser', async (fileChooser) => {
resolve(true);
await fileChooser.setFiles('/foo/bar.baz');
});
await this.app.evaluate(async ({ BrowserWindow, dialog }) => {
const win = BrowserWindow.getAllWindows()[0];
await dialog.showOpenDialog(win, {});
});
assert.ok(await promise);
});
});
Issue Analytics
- State:
- Created 3 years ago
- Reactions:17
- Comments:5 (1 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
Based on spectron-fake-dialog, I wrote a little library to fake electron dialog for playwright/electron, https://github.com/wsw0108/playwright-fake-dialog
@wsw0108 I tried your test repo, but the
native menu open filetest does not open any file. On a Windows machine, after the mock method, theclickMenuItemByIddoes not work. Without themockmethod it opens a dialog. Also, thesetTimeutis not fired because the test is finished before the timeout ended. Do you have any idea how to fix this?