[Feature]: Provide ability to pass CancellationToken into Async methods

Is there a way to use cancellation tokens to cancel async operations?

It would be helpful to have most of the async methods able to be cancelled. Especially methods like

await page.GotoAsync("https://github.com/");

which would then be:

await page.GotoAsync("https://github.com/", cancellationToken);

[schrufygroovy]

@mxschmitt this is true from a browser user perspective, but I think it’s really not about cancelling any actions/commands but more about cancelling potential waiting process for the callbacks of the commands.

As far as I can see all commands are sent via SendMessageToServerAsync() - and for each command the callback is being awaited. Why should it not be reasonable to cancel this instead of waiting for callback to be fulfilled? For example when I want to cancel the execution (e.g: some test run, or some executable), why would I still need to wait until the await page.GotoAsync("https://github.com/") command is having some callback. I just want the execution to be stopped gracefully as fast as possible and no “hanging” execution.

I would really appreciate, if you would reconsider your decision or give us some alternative way to gracefully cancel pending commands.

[avodovnik]

Hi! Thanks for the suggestion. This is definitely something to consider. For now, I’ve marked it as collecting feedback, and we’ll go from there.