Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Feature] Downloads

See original GitHub issue

It would be nice to have an api like:

page.on('download', async download => {
   const buffer = await download.data();
   console.log('got download', download.url(), buffer.length);
});

We can hack it with Page.setDownloadBehavior in chromium and monitoring the download folder, but it would be nicer to have something like download interception in all of the browsers.

Should the event come when the download starts, or when it finishes? I think when it starts.

Previous discussion in puppeteer: puppeteer/puppeteer#299

Issue Analytics

State:
Created 4 years ago
Reactions:14
Comments:5 (2 by maintainers)

Top GitHub Comments

5reactions

DavertMikcommented, Feb 6, 2020

I love the API! However, I am really fine with just specifying the download directory without intercepting the request on its own. If I could have a file saved in a proper directory I can open it by myself once it is written and do all manipulations there.

It would be nice to have an event like donload.complete but I’m not sure where this event should be attached… Anyway, at this moment we can just monitor directory for a file and that’s enough for us!

1reaction

joelbyfordcommented, Feb 7, 2020

Believe that comment was for @JoelEinbinder instead 😄