[Question] - Hooks and teardown

Hi guys, quick question, is it always recommended to use test.afterAll or afterEach when using the page fixtures in a spec file ? I have a couple of specs and noticed some issues when running them on azure with the error:

“Test timeout of 30000ms exceeded while tearing down “context”.”

It is intermittent , but seems to have stopped when adding page.close() in the afterEach hook. However, I could see there is no afterEach hook in the example class created automatically when installing playwright (So I was not sure if it is 100% needed or not)

I have one spec with different test cases using the page fixture and another one that loops through a list of values to execute the tests, and it happened in both of them. I.e:

Example1:

text.describe({
   test('test1' , async ({page})=> {
      //do something
   })
   
   test('test2' , async ({page})=> {
      //do something else
   })
})

Example2:

test.describe({
        for(const value of values){
          test(`test ${value}`, async ({ page }) => {
          await page.goto(`/value`);
        });
    }
})

[aslushnikov]

That would be awesome. We didn’t find anything that might affect this kind of behavior change from 1.25 to 1.26, so a repro would drastically help us debug this issue.

Let me close this for now, but please file another issue as you have a repro. (this way we won’t accidentally forget about it).

Thanks!

[imartinflores]

Seeing the issue on 1.25 intermittently as well, so I definitely assume it has something to do with the app itself. However the Traces and what can be seen on the video confused me a little bit. In the last Trace I got, I can see a page.close() timing out