[REGRESSION]: _videostarted event not fired in 1.6.2 but does in 1.4.0

Context:

• GOOD Playwright Version: 1.4.0
• BAD Playwright Version: 1.6.2
• Operating System: Linux 5.4.0-56-generic #62-Ubuntu SMP Mon Nov 23 19:20:19 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
• Extra: https://www.youtube.com/watch?v=DklP4iB5QdY

Code Snippet

(using exact code from release notes) https://github.com/microsoft/playwright/releases/tag/v1.4.0

const fs = require('fs');
const { chromium } = require('playwright');

(async () => {
  const browser = await chromium.launch({
    _videosPath: __dirname  //  save videos here.
  });
  const context = await browser.newContext({
    _recordVideos: { width: 1024, height: 768 },  // downscale
  });
  const page = await context.newPage();
  const video = await page.waitForEvent('_videostarted');
  await page.goto('https://github.com/microsoft/playwright');
  // ... perform actions
  await page.close();
  fs.renameSync(await video.path(), 'video.webm');
  await browser.close();
})();

Describe the bug

The _videostarted event fires in 1.4.0 but does not in 1.6.2 with the same code snippet. Attached video shows both happy path and sad path

The exact error message from 1.6.2 is:

Timeout while waiting for event "_videostarted"

[chrisjsimpson]

Thanks @aslushnikov 🙏

I’ve also since found the helpful test which you committed to very helpful as example code: https://github.com/microsoft/playwright/blob/1c39689dd6e8b163ed77114f7aa40fac0063c38b/packages/installation-tests/screencast.js#L44

I’ll update with further example, thank you for your help both.

[mxschmitt]

Hi, the API was changed, see here for the new API: https://playwright.dev/#version=v1.6.2&path=docs%2Fapi.md&q=browsernewpageoptions--options-recordvideo