VS Code interacts poorly with Watchman-based fsmonitor, causing many Git commands running in background

Hi, since I registered my react project for scalar I noticed that every 5 seconds a bunch of git commands is done in background for every file opened in Visual Studio code. Such a bunch is done every 5 seconds for every opened file:

> git status -z -u
> git symbolic-ref --short HEAD
> git rev-parse [...]
> git rev-parse --symbolic-full-name [...]@{u}
> git rev-list --left-right [...]...refs/remotes/origin/[...]
> git for-each-ref --sort -committerdate --format %(refname) %(objectname)
> git remote --verbose
> git config --get commit.template

This slows down vscode significantly when there are several files open.

Unregistering the project from scalar does not help. Only when removing the git config entries scalar adds the problem is solved:

       [...]
	multiPackIndex = true
	preloadIndex = true
	safecrlf = false
	untrackedCache = false
	hookspath = C:/project/.git/hooks
	fsmonitor = C:/project/.git/hooks/query-watchman
	fsmonitorHookVersion = 2

ENV:

• latest Windows10
• scalar: 20.06.171.1

[jeffhostetler]

I updated the builtin fsmonitor daemon code to put the cookie file deeper in the .git directory and confirmed that that prevented VSCode from overreacting when the daemon was active.

I need to independently fix and/or test the Watchman hook-based version.

[derrickstolee]

@derrickstolee the wathcman enty is causing it: fsmonitor = C:/project/.git/hooks/query-watchman as soon as I remove it vscode behaves as usual.

will scalar work without that entry properly or should I un-register to avoid other strange behavior?

Scalar will work without the fsmonitor feature. (In fact, it will not configure it if you do not have Watchman installed.)

THANK YOU @hbinkle for discovering the bad configuration value, and I will make sure we investigate why this feature is interacting badly with VS Code!

I hope you don’t mind, but I’m going to rename this issue to track the real cause.