Enum validation fails when enum is defined in separate thrift file

We noticed an error like this when running code gen:

E: 'One' is not a member of enum type Foo: members=[One]

with testing_foo.thrift defined as:

namespace java testing 

enum Foo {
  One = 1
}

and testing_bar.thrift defined as:

namespace java testing

include 'testing_foo.thrift'

struct Bar {
  1: required testing_foo.Foo foo = Foo.One;
}

(This happens with required testing_foo.Foo foo = Foo.One and required testing_foo.Foo foo = One)

For reference required testing_foo.Foo foo = 1 seems to work fine.

It seems like the linking happens correctly, just the validation fails.

[benjamin-bader]

Just confirmed my reading using the Apache compiler:

a.thrift:

namespace java a

enum Foo {
  One
}

b.thrift:

namespace java b

struct Bar {
  1: required a.Foo foo = One
}

$ thrift -gen java b.thrift
> [FAILURE:/Users/bendb/Development/thrift/b.thrift:6] error: identifier One is unqualified!

I’ll have a fix for the initial bug, but don’t want to deviate from Apache’s behavior more than necessary; we’ll match this validation behavior.

[benjamin-bader]

OK, I’ve finally got some time to address this. As I’m looking over the Apache compiler, it certainly appears that unqualified enum references in constants (e.g. required testing_foo.Foo foo = One) are not accepted; this is as of version 0.9.3. What version are you using that allows this?

t_const_value.h is approximately the same things as Thrifty’s ConstValueElement, and defines accessors used during const validation. The ones relevant to enums throw exceptions (i.e. fail) during const validation: https://github.com/apache/thrift/blob/0.9.3/compiler/cpp/src/parse/t_const_value.h#L107

How was this working for you previously?