Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

The plot methods in Datasets should be flexible

See original GitHub issue

As a user I will frequently want to plot images, predictions, masks, etc. The current definition of plot in RasterDataset is limited.

Issue Analytics

State:
Created 2 years ago
Comments:13 (6 by maintainers)

Top GitHub Comments

1reaction

calebrob6commented, Nov 11, 2021

Yep makes sense! I just see that as part of the normal work (and not like an extra burden).

I think we roughly agree (that plotting should happen in the dataset, that it should assume the values it gets are the same values that are returned by a call to getitem, and that we should return a figure).

The only tricky part I see is “denormalizing” samples in val_step(...) (or anywhere in a LightningModule). If a LightningModule knows about its DataModule then this should be fixed!

1reaction

calebrob6commented, Nov 11, 2021

(I’m not understanding you) So you think title and suptitle should be non optional?

For kwargs, I can see where your coming from – but now, how do they get routed to the correct imshow(...). E.g. for a plot(...) for a land cover dataset you will have an imshow(imagery) and also an imshow(mask, cmap=default_cmap, vmin=0, vmax=7, interpolation="none"). You would need to have separate kwargs routed to both of them. Then, for other datasets maybe you only have a single imshow(...).