--noImplicitThis error is inconsistent

TypeScript Version: 3.0.0-dev.20180707

Code

declare function f(a: any): void;
f(function() {
	this.m();
});

f({
	callback: function() {
		this.m();
	}
});

Expected behavior:

With --noImplicitThis, errors in both cases or neither case.

Actual behavior:

Only error in the first case.

[andy-ms]

That situation seems even worse because you never declared an any anywhere. But it would be likely to be fixed when this one is, so I’ll make it a part of this issue.

class x {
    public variable: number = 0;
    public x() {
        const c = [];
        c.push({
            xxx () {
                console.log(this.variable); // Should error
            }
        });
    }
}

A workaround is to declare an explicit type for c, as in const c: Array<{ xxx(): void }> = [];.

[andy-ms]

Array.push should have a parameter of type T where T is the array’s element type. With --noImplicitAny enabled, if the array didn’t have a declared type we should be inferring one – not just making it any.