cmd+click function name goes to type definition file instead of source

duplicate of microsoft/vscode#68782 but that was closed without fix.

• VSCode Version: 1.41.1
• OS Version: macOS 10.14.6

Steps to Reproduce:

1. Create a project folder with 2 files:

lib.js

export const testMethod = (name, params) => {
  params && params.age
    ? `hello ${name} with age: ${params.age}`
    : `hello ${name}`;
};

test.js

import { testMethod } from "./lib";
testMethod("foo", { age: 3 });

cmd+click works and jumps to definition.

now add a type definition file

lib.d.ts

declare namespace MyModule {
  interface IParams {
    age: number;
  }

  function testMethod(name: string, params: IParams): string;
}
export = MyModule;

cmd+click jumps to type definition instead of source definition.

I do not think this should be the default behavior. I would expect cmd+click to bring me to the function definition.

[tnrich]

@mjbvz

Hand authoring d.ts files for js files that you already have the code for is sort of an odd case.

I would argue that this is actually a very frequent case, think of all the pure js libraries that have d.ts files. IMO there should be a way to jump to either the definition file or completely disregard the definition file and jump to the source code.

[RyanCavanaugh]

From an architectural perspective, this is a bit of a jump for us. If there’s a .d.ts file, we don’t even look for .js and wouldn’t realize that there was another option to even go to. If we did decide this was worth investing in based on feedback, there’d need to be a separate verb so that we didn’t spend a bunch of timing trying to load JS files the user wasn’t interested in.