Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Wrong signature for WebKitEntriesCallback/WebKitErrorCallback/WebKitFileCallback

See original GitHub issue

I was trying to override callback interface signature for WebKitEntriesCallback/WebKitErrorCallback/WebKitFileCallback, added below json in overridingTypes.json:

    {
        "kind": "callback",
        "interface": "WebKitEntriesCallback",
        "signatures": [
            "(entities: WebKitEntry[]): void"
        ]
    },
    {
        "kind": "callback",
        "interface": "WebKitErrorCallback",
        "signatures": [
            "(err: DOMError): void"
        ]
    },
    {
        "kind": "callback",
        "interface": "WebKitFileCallback",
        "signatures": [
            "(file: File): void"
        ]
    }

based on .file() and .readEntries(). Related Typescript repo issue #18139

Then I changed baselines/dom.generated.d.ts to:

interface WebKitEntriesCallback {
    (entries: WebKitEntry[]): void;
}

interface WebKitErrorCallback {
    (err: DOMError): void;
}

interface WebKitFileCallback {
    (file: File): void;
}

But when I run ./build to build and test, dom.generated.d.ts is still the same, the snapshot test for it failed. I am not familiar with F# here, is my json input wrong in this case, or it is a bug from the build script?

eg: in browser.webidl.xml, these callbacks defined as:

  <callback-interfaces>
    ...
    <interface name="WebKitEntriesCallback" extends="Object">
      <methods>
        <method name="handleEvent" type="void">
          <param name="entries" type="WebKitEntry[]"/>
        </method>
      </methods>
    </interface>
    <interface name="WebKitErrorCallback" extends="Object">
      <methods>
        <method name="handleEvent" type="void">
          <param name="err" type="DOMError"/>
        </method>
      </methods>
    </interface>
    <interface name="WebKitFileCallback" extends="Object">
      <methods>
        <method name="handleEvent" type="void">
          <param name="file" type="File"/>
        </method>
      </methods>
    </interface>
  </callback-interfaces>