Prefer type correct import for add missing import for quick fixes

Bug Report

From https://github.com/microsoft/vscode/issues/115370

🔎 Search Terms

• Quick fix
• auto import

🕗 Version & Regression Information

Tested version: 4.2.0-dev.20210201

⏯ Playground Link

N/A

💻 Code

For the project:

// a1.ts
export const abc = 123

// a2.ts
export const abc = '123'

// index.ts
function foo(x: string) { }

foo(abc); // trigger quick fix here

1. Trigger the quick fix on abc in foo(abc)

🙁 Actual behavior

The import quick fixes are returned in file order:

Accepting the first suggestion results in invalid code:

🙂 Expected behavior

In this case, we should sort the import for a2 before a1 since it has the correct type

[mjbvz]

@RyanCavanaugh Yes, thinking about this more I agree this is probably not feasible for auto import suggestions right now.

For quick fixes though, the lightbulb generally should not produce invalid code so I think it does make sense to be smarter for those. Quick fixes are also being requested less often, so we don’t have the same performance concerns as with suggestions.

In VS Code, we also have an ‘auto fix’ command that will try to automatically apply the best quick fix to address a problem. It would be great if auto fix knew to use the type correct import by default instead of always defaulting to the first returned import suggestion

[RyanCavanaugh]

That distinction makes sense 👍