Spreading props in JSX on right hand side of && operator gives incorrect undefined warning

Bug Report

🔎 Search Terms

Spread, Spreading, &&

🕗 Version & Regression Information

• This is the behavior in every version I tried, and I reviewed the FAQ for entries about prop spreading.

⏯ Playground Link

https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAJQKYEMDG8BmUIjgIilQ3wG4AocmATzCTgGFdIA7JFmAeTYAUcwAznAC8cAN7k4cGMBgAbJAC44AmFGAsA5hQC+FcmggtVjZkfZc2IuAAox02Qrg7lTcOY7ckfCIICUIgB84pJwRDAArlAscAA8ABYAjIFiMvJIOrEA9EmBuvo0dKbubBwAKgDuED6C1hJSaQqVEAD8yqrqWvmUhsbwbqwWzdZ2DunDLsWD5VU1AgHCwfVwvSaGJRZec3WhDY5KY01VADSheqHhUTGNSMMAZHdxAx6W9GIAdJ-r069zOnBZPLkc7kJAAD0gsDgABMkJgUBE5P0zKUYM0KFksnAALLUFYQWFwTQQJBCeJIIhAA

💻 Code

import React from "react";

type ComponentOneProps = {
  title: string;
};

const ComponentOne = ({ title }: ComponentOneProps) => {
  return <h1>{title}</h1>;
};

type ComponentTwoProps = {
  titleTwo?: string;
};

const ComponentTwo = ({ titleTwo }: ComponentTwoProps) => {
  const componentOneProps = {
    title: titleTwo,
  };
  return titleTwo && <ComponentOne {...componentOneProps} />;
};

export default ComponentTwo;

🙁 Actual behavior

Because we checking that titleTwo is truthy here (as it’s the first operand of the logical AND operator) - the title prop of ComponentOne can never actually be set to undefined, but we get a warning saying type Type 'string | undefined' is not assignable to type 'string'.

🙂 Expected behavior

I would expect no error here, as the title prop can never be actually set to a falsey value on ComponentOne there. I think this may be an issue with spreading the props onto ComponentOne here as it works if you set the title prop directly:

[MartinJohns]

Here’s a simplified example of what you’re trying to do:

const value = undefined as string | undefined
const obj = { value }
if (value) {
  const expected: string = obj.value
}

Narrowing the value you stored in an object previously will not narrow the object.

[fatcerberus]

@karlhorky See this comment, which in turn links to this comment chain.