Suggestion: Type annotations and interfaces for function declarations
See original GitHub issueCurrently in TypeScript, function declarations cannot be typed in the same way as function expressions, e.g. this function can implement the React.FC
interface:
interface TestProps {
message: string
}
const Test: React.FC<TestProps> = ({ message }) => {
return <div>{message}</div>
}
But this function can’t, at least not directly:
function Test({ message }: TestProps) {
return <div>{message}</div>
}
This becomes more of an issue if you try to add properties to the function object:
Test.defaultProps = {
message: 'hi'
}
It seems that currently the only way to specify the type for the function object in the second example is to create a new variable:
const AliasForTest: React.FC<TestProps> = Test
AliasForTest.defaultProps = {
message: 'hi'
}
This seems like kind of an ugly workaround, so it seems that the current idiom is to just prefer arrow functions for cases like this. But this leads to inconsistency on teams that generally prefer function declarations over const expressions for top-level functions. Personally I find it more readable to see the word “function” for top-level functions rather than seeing “const”, which is generally already all over the place in the code. There is even an ESLint rule for teams that share my preference (although I don’t think it’s been ported to TSLint yet): https://eslint.org/docs/rules/func-style. In any case, I have seen others express similar views and other codebases (including some from Facebook and Apollo, for example) that still prefer the “function” keyword for top-level functions.
However, stylistically it’s also a problem if top-level functions are declared some places as declarations (using function
) and in other places as expressions (using const
). But for those who desire consistency, TypeScript is basically forcing the use of expressions, due to the issues described above.
This is far from being a top priority of course, but I was surprised to see that TypeScript didn’t provide some equivalent typing syntax for function declarations. It would be great if this could be considered for a future version (even if far in the future). Thanks for reading!
Issue Analytics
- State:
- Created 6 years ago
- Reactions:72
- Comments:29
Top GitHub Comments
@DanielRosenwasser I’m going to take my chances here, but the more I use TS and need to create a component with generics, the more I need this to be implemented. So, here is a polished version of my proposal:
implements
keyword for functions to create a function contract interface.implements
keyword is currently used to create a class contract, extending the standard ES classes with OOP features. Theimplements
keyword would be in the position as they are used in classes, after the generic declaration. Unlike classes, functions require parenthesis for arguments declaration. This declaration would start right after the implementation finished. The wholeimplements
implementation could be removed in order to produce valid JS code, as it is done in ES classes. Supporting generics would be a required feature for this to work, and having theimplements
implementation after the function generic declaration allows the generic to be used in the scope of theimplements
. The type or interface implemented withimplements
can be anything. Call signatures in the given interfaces should be used to define the signatures of the function. If a class interface is used, the function should produce a function constructor.To consider:
Some examples of this in pseudo-real life code:
React component example
Reducer example
I think this could be the best way this could get implemented. Anything that I can do to help with this, I’ll try to do it.
Update:
Please, consider this syntax can also be applied to anonymous functions and arrow functions as well:
React component example (anonymous function)
React component example (arrow function)
I just was thinking about this. I would like to make a proposal to type functions declarations, by adding to the function keyword a generic param that can shape the function.
To be used like this:
Variadic types are currently being tracked at #5453, but maybe this isn’t need for this to work, and this can be implemented somehow with the current union types, or the same way interfaces like this are being currently declared, but duplicating the amount of interfaces a having a any default to the
nth
interface.Another proposal, should be supporting
@type
property of JSDocs. With this, we can be able to type functions.