Type JSX elements based on createElement function
See original GitHub issueTypeScript currently uses a JSX namespace to type the props of JSX elements. This is customisable by modifying JSX.IntrinsicElements
, JSX.ElementClass
. However, the type of an element is always JSX.Element
.
Of course more interfaces could be added to the JSX
namespace. However, I think that with less effort, the compiler could be made more flexible. I’d propose to check JSX elements based on a (virtual) call to JSX.createElement
. For instance, the current behaviour can approximately be written like this:
namespace JSX {
// intrinsic elements
function createElement<K extends keyof JSX.IntrinsicElements>(tag: K, props: JSX.IntrinsicElements[K], children: JSX.Element[]): JSX.Element;
// class and functional components
function createElement<P>(component: (JSX.ElementClass & { new(): { props: P } }) | ((props: P) => JSX.Element), props: P, children: JSX.Element[]): JSX.Element;
}
Given that function signatures are well customisable with the use of generics for instance, most requests can be implemented this way. For instance, #13890 and #13618 would benefit from this change. Libraries that use JSX, but not on the React-way, will benefit from this too.
Proposed semantics
For a JSX element, a virtual call to JSX.createElement
is constructed. It is passed three arguments:
- Tag name (string) in case of an intrinsic argument (
<div />
). Otherwise, the identifier is passed (Foo
for<Foo />
). - An object containing the props.
- An array containing the children.
This should be roughly the same as the JSX transform used in the emitter phase. One notable difference is the following: in case of no properties or no children, an empty object or an empty array should be passed, instead ignoring the argument. This makes it easier to write JSX.createElement
for library authors.
Backwards compatibility
For backwards compatibility, one of the following approaches could be taken:
- Use old logic if
JSX.createElement
does not exist. - If
JSX.createElement
does not exist, default it to (roughly) the definition above.
Error reporting
When type checking the generated function call, the checker can give error messages like "Argument of type … " or “Supplied parameters do not match any signature of call target”. These messages should be replaced when checking JSX elements.
Issue Analytics
- State:
- Created 7 years ago
- Reactions:138
- Comments:33 (7 by maintainers)
Top GitHub Comments
Having this would allow one to utilize the concept of generalized JSX with TS. Currently it seems impossible, because the return type of any JSX expression is always a non-generic
JSX.Element
.In fact, given this it would make sense to ditch the whole “JSX” global namespace and just use the declared type of the locally scoped
jsxFactory
(set in thetsconfig.json
), so that the return type of a JSX expression could be different in every file, based on the implementation of thejsxFactory
.Could this be added to the roadmap again? Compiler API and JS synergy are both extremely cool, and definitely more important, but this could provide some kick-ass inference with JSX children in much more than just React applications. And it’s a little frustrating to see the dust falling on the PR that should have fixed this a year ago…