[typescript] removing a bracket loses all folded areas

TS Template added by @mjbvz

TypeScript Version: 4.1.0-dev.20201002

Search Terms

• folding / folds
• getOutlineSpans

(see my comment for a self contained example)

---

• VSCode Version: 1.47.0
• OS Version: Windows 10 Verison 1909

Steps to Reproduce:

1. make an error on the code with all lines collapsed.
2. It will automatically expand all the codes. Which is annoying. Bcuz I have to collapse it automatically.

Does this issue occur when all extensions are disabled?: Yes

[vscodebot[bot]]

(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Compact explorer tree nodes don’t narrate “Expanded” and “Collapsed” (#86414)
• Test: Notebook cell collapse (#103887)
• large format change losses folding ranges (#86621)
• Allow right arrow on a collapsed cell to expanded (#104116)

[andrewbranch]

Maybe if a change results in both 1) the removal of a folding range that’s currently folded, and 2) a syntax error that intersects that range, you could leave it intact? Not sure if you’d have to throw out our entire response of new folding ranges or if it would sometimes be possible to merge them. When you request folding ranges, do you already have syntactic diagnostics? The immediate problem I see with calculating all this on our side is that by the time you ask for new folding ranges, we no longer know what the old ones are (not to mention, we don’t know what regions have been folded, and all this is irrelevant if the user isn’t folding anything).