applyTo: closedDocuments and a custom owner caused errors to leak/persist
See original GitHub issueDoes this issue occur when all extensions are disabled?: Yes/No
- VS Code Version: 1.67.2
- OS Version: macOS 12.3.1
Steps to Reproduce:
- Create a tsup project with the following task:
{ "owner": "tsup", "source": "tsup", "applyTo": "closedDocuments", "severity": "error", "pattern":[ { "regexp": "^✘\\s+\\[ERROR\\]\\s+(.+)$", "message": 1 }, { "regexp": "^\\s*$" }, { "regexp": "^\\s+(.+):(\\d+):(\\d+):$", "file": 1, "line": 2, "column": 3 } ], "background": { "beginsPattern": "^CJS Build start$", "endsPattern": "^CJS .* Build success|^CJS Build failed" } },
- Introduce a syntax error in a ts file like just typing
%
in a line. - Open/close the file, the error doesn’t disappear on opening the file.
- The error persists even after fixing the error in the file.
Removing "applyTo": "closedDocuments"
makes it work. It appears like applyTo
is getting messed up with a custom owner like tsup
that isn’t the language of the file or something?
Issue Analytics
- State:
- Created a year ago
- Comments:8 (8 by maintainers)
Top Results From Across the Web
No results found
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
It has to be a syntax error, so just an “s” which is valid syntax but a type checking error won’t trigger a tsup error. I also had to close the file and reopen it to trigger this for some reason.
@meganrogge Can you try again using a
%
and saving, closing, and reopening the file, after adding it?Thanks!
I still can’t reproduce with your exact above steps
https://user-images.githubusercontent.com/29464607/169900110-a2ef5bb5-d08a-467d-b76c-c25efcf2a7de.mov