Auto save & new line prevents undo from working

• Version: 1.41.0
• Commit: 9579eda04fdb3a9bba2750f15193e5fafe16b959
• Date: 2019-12-11T17:58:38.338Z
• Electron: 6.1.5
• Chrome: 76.0.3809.146
• Node.js: 12.4.0
• V8: 7.6.303.31-electron.0
• OS: Darwin x64 19.2.0

Steps to Reproduce:

1. set "files.trimFinalNewlines": true and "files.autoSave": "afterDelay"; edit: instead set "files.insertFinalNewline": true to follow POSIX conventions
2. move the caret to the very end of the file
3. insert a string at the very end of a file
4. a new line is automatically added
5. try to undo step 3 will remove the new line, which is then added again

Does this issue occur when all extensions are disabled?: Yes

[quassy]

I know this is as designed and is what I want, because very line has to have a \n at the end to be POSIX compatible i.e. work well under UNIXoid systems et cetera. I don’t mind seeing it rendered, also changing the setting to false doesn’t prevent the bug.

The bug report is about Undo not working: It’s impossible to undo any input you do on that said last line, because “auto insert newline” is the last undo action and not “paste text” as it should be because it’s the actual last user action.

[alexdima]

@quassy

"files.insertFinalNewline": true means the file will be saved to disk with a \n as the last character… No matter what the buffer contents are before the save, the file will be saved to disk with \n as the last character (I think there is an exception for empty files, but otherwise, \n is always added at the end of the buffer by a save participant. This is “as designed”.

If you don’t like to see the extra new line, you could use "editor.renderFinalNewline": false…