Cap number of sticky scroll lines (esp inside peek view)

Type: Bug

When I check git diff directly in the vscode editor, the sticky scroll is enabled, and it’s overlap the content of the peek view

VS Code version: Code 1.71.0 (Universal) (784b0177c56c607789f9638da7b6bf3230d47a8c, 2022-09-01T07:25:38.437Z) OS version: Darwin arm64 21.3.0 Modes: Sandboxed: No

System Info

Item	Value
CPUs	Apple M1 Pro (10 x 24)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off
Load (avg)	4, 6, 6
Memory (System)	16.00GB (0.07GB free)
Process Argv	–crash-reporter-id abed5057-1cf3-418c-9b06-4d1438cc4e87
Screen Reader	yes
VM	0%

Extensions (33)

Extension	Author (truncated)	Version
vite	ant	0.2.5
vscode-custom-css	be5	7.1.0
vscode-tailwindcss	bra	0.8.6
vscode-toggle-quotes	Bri	0.3.6
turbo-console-log	Cha	2.5.1
vscode-eslint	dba	2.2.6
vscode-styled-jsx-languageserver	Div	1.3.1
vscode-styled-jsx-syntax	Div	1.3.1
githistory	don	0.6.19
es7-react-js-snippets	dsz	4.4.3
gitlens	eam	12.2.1
prettier-vscode	esb	9.8.0
auto-rename-tag	for	0.1.10
vscode-pull-request-github	Git	0.50.0
go	gol	0.35.2
vscode-graphql-syntax	Gra	1.0.4
todo-tree	Gru	0.0.215
vue-snippets	hol	1.0.4
vscode-peacock	joh	4.2.0
dotenv	mik	1.0.1
zeit-co-vscode-schemas	ph1	0.1.2
prisma	Pri	4.3.1
json-schema-2020-validation	pro	0.0.5
nextjs-snippets	Pul	0.0.5
vscode-yaml	red	1.10.1
vscode-javascript-booster	sbu	14.0.1
sass-indented	syl	1.8.22
vscodeintellicode	Vis	1.2.24
vscode-icons	vsc	11.16.0
fig	wit	0.0.6
glean	wix	5.2.2
markdown-pdf	yza	1.4.4
html-css-class-completion	Zig	1.20.0

(4 theme extensions excluded)

A/B Experiments

vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonvspyt551:30345470
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411cf:30557515
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
pylanb8912:30545647
vsclangdc:30486549
c4g48928:30535728
hb751961:30553087
dsvsc012cf:30540253
azure-dev_surveyone:30548225
i497e931:30553904

[Hacksore]

My take is we should be able to opt in or out of showing them in the peek views.

If you look at my scenario I wanted to instantly know what the change was here. However, since the sticky scroll is in the peek view that requires a bit of scrolling and blocks a significant amount of information I get from the diff.

I do think that @maxime4000’s solution to limit the amount rows it shows could help but personally I don’t want to see them in diffs as to me they seem less useful there.

Perhaps something like a checkbox to allow or disallow it?

[maxime4000]

I would keep the sticky scroll in peek view, but turn down how many row does it show. Here’s some ideas:

• Reduce the number of sticky scroll to 3 in peek view with first, median, last row sticked.
  • Or RoundUp(number of sticky row / 2.5) = number of sticky row displayed in peek view
• “Smart row” keeping, last sticky row, last function and first class or “big container”