question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Comments API: resolved/unresolved comments

See original GitHub issue

The comments API doesn’t have the concept of resolved/unresolved threads, although most code review tools distinguish them. The current API allows us to surface this to the users, see https://github.com/microsoft/vscode/issues/122243

However, this seems pretty limited. I find it difficult to identify all my unresolved comments. It’s very easy to miss some of them. If the API had a boolean for unresolved comments, we could surface them in multiple ways:

  • In the Comments panel, surface the number of unresolved comments, similar to what is done with Problems: comments number
  • In the Comments panel, highlight the unresolved comments (or put them in bold), so that it’s obvious to the user what comments they still have to go through.
  • In the Comments panel, have a way to hide/filter the resolved comments.
  • In the Editor, consider consider using a different background color for unresolved comments. I currently use a different label for unresolved comments, but this is very subtle.
  • In the gutter, use a different symbol for unresolved comments (e.g. or a diamond of another color).
  • In the Editor, provide a way to go to the next unresolved comment (an alternative to Go to Next Comment Thread).

Issue Analytics

  • State:open
  • Created 2 years ago
  • Reactions:17
  • Comments:14 (12 by maintainers)

github_iconTop GitHub Comments

5reactions
isidorncommented, Nov 19, 2021

@laurentlb Thank you very much for your proposal. @rebornix, @alexr00 and me have quickly discussed this and we believe this proposal makes good sense. We plan to start looking into it next milestone. Though no promises yet when this will land, we will know more in December when we start our investigation.

3reactions
alexr00commented, Apr 21, 2022

If anyone is eager for this API to be finalized then please comment and let me know how it’s working for you. Otherwise, I will plan to finalize later in 2022.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Google Drive comments API showing unresolved ...
I have a Google Doc that I am testing the Comments API with. I've created, then deleted or resolved many comments.
Read more >
API Get Comment from unresolved cases
Hi this query shows all comments in all Jira's in a project via API. How can I limit that to only cases that...
Read more >
Gerrit Comment Resolved Status
I have 2 questions about the resolved/unresolved status of Gerrit comments: 1) Is there a way to set that status (to resolved or...
Read more >
Ability to make a comment `unresolved` or `needs resolving`
Issue comments. Commits; Snippets. Resolvable threads (i.e. resolvable discussions) for: Merge request comments. Design. The new comment ...
Read more >
9541 - Unresolved comments are evaluated incorrectly and ...
Furthermore, when replying to a comment with the old UI, the resolved status is inherited from that parent comment. So, replying inline to...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found