ESLint@^8 cannot format the code when saving

Hi, After my test, ESLint@^8 cannot format the code when saving with the following configuration, and versions ^5 to ^7 do fine.

"editor.codeActionsOnSave": {
    "source.fixAll.eslint": true
}

I don’t know if this issue is reported to eslint or vscode-eslint.

[MariaSolOs]

@vvizden I just cloned your repo and everything worked for me.

Seems because of this config: "eslint.codeActionsOnSave.rules": [],

That makes sense. That setting lists the rules that should be auto-fixed when saving/formatting a file. If it’s empty, the extension will not make any changes. If not defined, then the default is to use the rules in the .eslintrc file.

But why is versions ^5 to ^7 not affected by it.

Good question. The README says:

So what I think was happening is that with earlier versions of ESLint this extension would just ignore your "eslint.codeActionsOnSave.rules": [] setting, but now that you’ve upgraded to v8 it results in the behavior explained above.

[vvizden]

Thank you very much for the careful answer, and here is a summary to help friends who encounter the same problem.

Solve this problem quickly：

It doesn’t matter which version of eslint ( now the latest version is 8.27.0 ) in package.json, just remove the "eslint.codeActionsOnSave.rules": [] in your VSCode settings.json.