eslint.autoFixOnSave does not trigger consistently

Hi 👋

First of all, thanks a lot for your work, this plugin is amazing and I use it everyday !

Unfortunately, sometimes (as described in eslint.autoFixOnSave doesn’t always fire on save #283) eslint shows all file errors correctly but does not trigger the file fixes on save when the setting is correctly set in vscode settings (either in User or Workspace settings).

As asked in #283 I set the setting eslint.server.trace to “messages” and observed that when the plugin does not work as expected this lines are not shown in the trace logs:

[Trace - 3:46:33 PM] Sending request 'textDocument/willSaveWaitUntil - (2)'.
[Trace - 3:46:33 PM] Received response 'textDocument/willSaveWaitUntil - (2)' in 110ms.

They are outputted just before textDocument/didSave in the normal situation, but not when the plugin does not fixe on save.

Also, Reload Window solves the issue temporarily, until it breaks again.

PS: I’m sorry because I just reload before sending this issue, so I don’t have the trace logs when it does not work. I’m add them in a following comment.

Thanks in advance for your time !

[ghost]

Happens to me all the time as well. It will work for a short while, then suddenly just stop working. My workaround is to restart vscode.

[verbumfeit]

After removing this editor.defaultFormatter - autofix works like a charm, and willSaveWaitUntil is showing in output.

I discovered it works with editor.defaultFormatter, you just have to add

"eslint.validate": [
  { "language": "typescript", "autoFix": true },
  { "language": "typescriptreact" , "autoFix": true} // If you use React
]

So the combination of autoFixOnSave and autoFix works, don’t know why though.