Use file location for `.eslintrc.js` resolution

It seems that when using multiple .eslintrc.js files throughout the workspace (of which some may use root: true), vscode-eslint doesn’t follow the same resolution algorithm that eslint itself uses.

It seems that eslint.workingDirectories could be a (very inelegant and manual) solution to this problem, by specifying every directory, that has an .eslintrc.js file as a working directory.

Is there no way for vscode-eslint to “just” follow the same resolution logic that eslint uses? Am I doing something wrong?

[buschtoens]

I think most issues can be traced back to an incorrect process.cwd().

I have a shareable config that looks up the package name from the package.json of the project, to configure import-helper/order-imports. It basically does this:

const APP_NAME = require(`${process.cwd()}/package.json`).name;

module.exports = {
  plugins: ['import-helpers'],
  rules: {
    'import-helpers/order-imports': [
      'error',
      {
        newlinesBetween: 'always',
        groups: [
          // ...
          [`/^${APP_NAME}\\//`],
          // ...
        ],
        alphabetize: { order: 'asc', ignoreCase: true }
      }
    ]
  }
};

I have a monorepo with a package.json at the root of the repository, that basically looks like this:

// ./package.json
{
  "name": "my-monorepo",
  "workspaces": [
    "packages/*"
  ]
}

And then in the package where I use my shareable import-helper/order-imports config, I basically got this package.json:

// ./packages/some-app/package.json
{
  "name": "some-app",
  "scripts": {
    "lint:js": "eslint --ext ts,js ."
  },
  "devDependencies": {
    "@clark/eslint-config-ember": "^1.8.0",
    "eslint": "^6.1.0"
  }
}

And this .eslintrc.js:

// ./packages/some-app/.eslintrc.js
module.exports = {
  root: true,
  extends: '@clark/eslint-config-ember'
};

When I run yarn lint:js somewhere inside the some-app package (can even be a subdirectory of some-app), the process.cwd() is ./packages/some-app.

The require() shown in the first code snippet thus works like this:

process.cwd(); // => ./packages/some-app
const APP_NAME = require(`${process.cwd()}/package.json`).name; // => 'some-app'

When vscode-eslint runs the litner for this any file inside the some-app, package, the process.cwd() is ./ (the repo root).

The require() shown in the first code snippet thus works like this:

process.cwd(); // => ./
const APP_NAME = require(`${process.cwd()}/package.json`).name; // => 'my-monorepo'

I think vscode-eslint should do two things:

When a file is linted, traverse up the directory hierarchy and read all package.json files on the way. Once a package.json that lists eslint as a dependency is found, use it’s directory as the process.cwd() and also resolve eslint relative to this directory. As an added bonus, this allows using different versions of eslint in a monorepo, even though I would generally consider this to be an anti-pattern.

This would basically be an “automated” eslint.workingDirectories.

[buschtoens]

Whoops, didn’t mean to close this issue. GitHub did this for me, since I referenced this as Fixes in a PR in a private repo.

If any of the other participants feel that this should be reopened, I can do so. But at least for me, the issue is solved for now.