question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Explore improving search performance to support high `maxResults`

See original GitHub issue

extracted from https://github.com/microsoft/vscode/issues/8563#issuecomment-871226262

  • open vscode repo
  • have "search.maxResults": 200000000
  • search for ;
  • 🐌 notice how VS Code becomes slower and slower… I can see that each call to refreshAndUpdateCount takes close to 1 second and these calls happen repeatedly
Screen Shot 2021-06-30 at 11 07 10

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

2reactions
roblourenscommented, Jun 30, 2021

With the diffIdentityProvider, much improved:

image

Thanks for the tip @connor4312. And there are other easy optimizations to make on my end. With this many results, we can render less often or not at all. Nobody will read through 300,000 results, but we can keep them in the model for a replace.

1reaction
roblourenscommented, Jul 1, 2021

Not brave enough to make the needed changes for this release. Thanks @chrmarti

Read more comments on GitHub >

github_iconTop Results From Across the Web

Explore improving search performance to support high ` ...
Explore improving search performance to support high `maxResults` #25748. Sign in to view logs · Sign in to view logs ...
Read more >
Understanding Performance Max results with the Insights page
Instead, Performance Max uses automation to help you drive better results towards ... search categories and search terms are converting at higher rates....
Read more >
JIRA Cloud REST API /rest/api/latest/search?maxResults ...
We decided to reduce the maxResults value not only due to increased performance and memory impact on Jira but also after observing the...
Read more >
Performance Tips | Search Ads 360 API
Another way to improve the performance of your API calls is by ... APIs that support query parameters for data pagination ( maxResults...
Read more >
The Ultimate Guide To Performance Max Campaigns (2023)
Performance Max is the hot thing in the world of Google Ads. So ... platform: Search, Shopping, YouTube, Display, Discover, Gmail, and Maps....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found