Explore using formatters for indentation adjustment when formatters are available

VSCode 1.9 introduced initial support for line indenting as per the release notes, I think it’s this commit: https://github.com/Microsoft/vscode/commit/be1b5f75161a30dd63316b832067b41d2caec0b3. I’m very interested in this feature, big 👍 for bringing it into VSCode.

Here is some initial feedback:

• I tried for a couple of file formats, it only worked for TypeScript and not e.g., for JSON or PHP.
• Formatting (Alt+Shift+F) can already do indentation better than the new implementation, maybe it could be used as a fallback if the language doesn’t have proper indentation rules.
• If I read the code correctly, it re-indents the whole file. It should respect my selection. For example, if I have only 10 lines selected, it should re-indent those. If I don’t have any selection, it should do the whole file.
• The command is currently editor.action.reindentlines, proper casing would be editor.action.reindentLines.

[dobriai]

FWIW: This feature is a life-saver for me. As much as I appreciate js-beautify, it seems that it cannot be told not to mess with my white-space. Trying to format something like this:

let aha          = 7;
let badahabadaha = 9;

mangles it, by trimming the white space in front of ‘= 7;’ and thus looses the ‘=’ alignment! Big deal and I just don’t see a way to turn this behavior off.

Reindent Lines seems to do whatever most other editors do, so this is the cure for me. But it is very important to have a version that works on the current selection only!

[rebornix]

@borekb sorry I don’t have time working on this issue this iteration but it’s on my radar, I received similar issues or feedback on this every other day