Extension: During deactivate, globalState.update promises are immediately canceled

Issue Type: Bug

Minimal repro here, which consists of the default yo code-created extension with the changes summarized below:

let globalState: vscode.Memento;

export function activate(context: vscode.ExtensionContext) {
  // ...
  globalState = context.globalState;
  console.log(`Pre-existing keys: [${globalState.keys().join(', ')}]`);
  globalState.update('test', 'repro');
}

export async function deactivate() {
  try {
    await globalState.update('test', undefined);
    console.log('globalState.update succeeded');
  } catch (err) {
    console.log(`globalState.update failed with ${err}`);
  }
}

Repro Steps

1. Debug an extension (or install and run natively).
2. Activate extension (in this case with Ctrl-Shift-P “Hello World”)
3. Close VS Code
4. In extension deactive, delete a key from context.globalState, and return the resulting promise.

Expected: As long as the promise finishes within 5 seconds, the operation will complete.

Actual: The promise is canceled. In the repro shown here, the message globalState.update failed with Canceled: Canceled is emitted. The next time the extension is run, the extension prints Pre-existing keys: [test], verifying that the key was not removed.

VS Code version: Code 1.64.2 (f80445acd5a3dadef24aa209168452a3d97cc326, 2022-02-09T22:02:28.252Z) OS version: Windows_NT x64 10.0.19044 Restricted Mode: No

System Info

Item	Value
CPUs	Intel® Core™ i7-8700K CPU @ 3.70GHz (12 x 3696)
GPU Status	2d_canvas: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on rasterization: enabled skia_renderer: enabled_on video_decode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	15.94GB (2.63GB free)
Process Argv	–crash-reporter-id 1871b94c-c67d-43d1-b37d-bdf3332353ad
Screen Reader	no
VM	0%

Extensions (35)

Extension	Author (truncated)	Version
tsl-problem-matcher	amo	0.5.0
chronicler	arc	0.1.16
doxdocgen	csc	1.4.0
mustache	daw	1.1.1
vscode-eslint	dba	2.2.2
xml	Dot	2.5.1
vscode-npm-script	eg2	0.3.24
prettier-vscode	esb	9.3.0
godot-javascript-debug	gee	0.1.5
godot-tools	gee	1.1.3
better-cpp-syntax	jef	1.15.13
volar	joh	0.32.0
hjson	lak	0.3.2
template-string-converter	meg	0.6.0
python	ms-	2022.0.1814523869
vscode-pylance	ms-	2022.2.4
jupyter-renderers	ms-	1.0.6
remote-containers	ms-	0.217.4
remote-ssh	ms-	0.74.0
remote-ssh-edit	ms-	0.74.0
remote-wsl	ms-	0.64.2
vscode-remote-extensionpack	ms-	0.21.0
cmake-tools	ms-	1.9.2
cpptools	ms-	1.8.4
cpptools-extension-pack	ms-	1.1.0
live-server	ms-	0.2.12
powershell	ms-	2021.12.0
vscode-gn	npc	1.1.0
vscode-versionlens	pfl	1.0.9
svg-preview	Sim	2.8.3
shader	sle	1.1.5
es6-string-html	Tob	2.12.0
cmake	twx	0.0.17
sort-lines	Tyr	1.9.1
wallaby-vscode	Wal	1.0.327

(2 theme extensions excluded)

A/B Experiments

vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30443607
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30442554
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30433507
vsclayoutctrt:30437039
vsrem710cf:30416617
vscop841cf:30438916
dsvsc008:30440022
pythonvsnew555:30442236
vsbas813:30436447
vscscmwlcmt:30438805
vscgsvidc:30438801
helix:30440343
vsnot107:30443614

[gjsjohnmurray]

Related but probably a separate thread from all of this: I first started to implement cleanup tasks by returning Disposables from activate. Although dispose() is called at the same time as deactivate, Promises returned by dispose are not executed. That may be by design, but it is a little inconsistent. The dispose idiom also feels cleaner than passing state to deactivate via globals.

See https://github.com/microsoft/vscode/issues/140697#issuecomment-1017559485 and following.

[andreamah]

@andreamah this issue may be relevant to #128138 which you commented on and reopened today. I couldn’t add this comment there because when reopening it you forgot to unlock it.

oh, nice catch! thanks for letting me know!