Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Finalize or remove the notebookControllerKind API Proposal

See original GitHub issue

From https://github.com/microsoft/vscode-jupyter/issues/7373

Let’s figure out what to do with th notebookControllerKind API proposal. Jupyter is currently the only consumer of it

@rebornix @DonJayamanne Can you please let me know:

If/how Jupyter is using this API today
If, in your opinion, this API should finalized or not? Are there any know issues / gaps with it

Issue Analytics

State:
Created 9 months ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

rebornixcommented, Dec 9, 2022

@davidanthoff thanks for your feedback, they make good sense and we have discussed some of the wording, like using “Jupyter Kernel Specs”. We will address other feedback in issue https://github.com/microsoft/vscode/issues/168647

0reactions

davidanthoffcommented, Dec 9, 2022

Actually, here is another idea: if the notebookControllerKind property were to be finalized, then we could start to use it with the previous iteration of the UI in the same way that the Jupyter extension is using it right now.

In the new MRU UI, could the notebookControllerKind be the string by which the top level grouping happens? I.e. instead of using the description of the extension, or the name of the extension, could the notebookControllerKind be used if it is set?

That would enable a scenario where things move forward now before the MRU story is finalized, and then there would also be a use-case for the notebookControllerKind in the new MRU UI.

Also, I think this issue here is a dup of https://github.com/microsoft/vscode/issues/168535, but given that more discussion has happened here, it probably makes sense to close https://github.com/microsoft/vscode/issues/168535 and continue here.