Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Implement a preferences UI editor smoke test for `Preferences turns off editor line numbers and verifies the live change`

See original GitHub issue

Update

This was originally a test failure, but my suggestion in the end would be to come up with a settings smoke test that leverages the settings UI editor if possible.

Original:

https://dev.azure.com/monacotools/Monaco/_build/results?buildId=151025&view=logs&j=672276a2-8d3a-5fab-615d-090c51352f92&t=0699ae84-7245-5a45-5eee-80b086af2725&l=71

1) VSCode Smoke Tests (Electron)
       Preferences
         turns off editor line numbers and verifies the live change:
     Error: Timeout: get elements '.line-numbers' after 20 seconds.
      at poll (D:\a\1\s\test\automation\src\code.ts:109:10)
      at Code.waitForElements (D:\a\1\s\test\automation\src\code.ts:258:10)
      at Context.<anonymous> (src\areas\preferences\preferences.test.ts:23:4)

//cc @sandy081

Issue Analytics

State:
Created 2 years ago
Comments:34 (34 by maintainers)

Top GitHub Comments

2reactions

sandy081commented, Feb 2, 2022

@rzhao271 I think it would be a good smoke test for settings editor. We have similar test for keybindings editor.

1reaction

bpaserocommented, Jan 28, 2022

but I do not know how the window.driver thingy works

If you search for capturePage you can see an end to end of a method that is accessible from the smoke tests all the way into the running VSCode app where the method is implemented. Methods exposed from driver.ts can be used from smoke tests via the driver’s IPC channel. You should be familiar with that way of implementing an IPC channel as it is the same used for all our other IPC communications 👍

Can I enable these tests again

Yes, please do.

Top Results From Across the Web

Implement a preferences UI editor smoke test for `Preferences turns ...

Implement a preferences UI editor smoke test for `Preferences turns off editor line numbers and verifies the live change`. On Comment #93045 #93045....

February 2020 (version 1.43) - Visual Studio Code

Learn what is new in the Visual Studio Code February 2020 Release (1.43) ... Draggable sash corners - Easily change the editor layout...

Changing the Pop-up Blocker Settings in Chrome, Firefox, or ...

Open Internet Explorer, select the Tools button, and then select Internet options. 2. On the Privacy tab, under Pop-up Blocker, select or clear...

Tips and Tricks for Mac Management - Apple

editor. This domain allows the administrator to establish a setting, yet the user may be allowed to edit that preference during the session....

Preference - Android Developers

android:singleLineTitle, Whether to use single line for the preference title text. ... Editor where this Preference can save its value(s).