install-extension command throws Buffer deprecated warning

Issue Type: Bug

PS C:\Users\sagavale> & 'C:\Users\sagavale\AppData\Local\Programs\Microsoft VS Code\bin\code.cmd' --version
1.39.0
9df03c6d6ce97c6645c5846f6dfa2a6a7d276515
x64
PS C:\Users\sagavale> & 'C:\Users\sagavale\AppData\Local\Programs\Microsoft VS Code\bin\code.cmd' --install-extension ecmel.vscode-html-css                                                                                                                            Installing extensions...
Installing extension 'ecmel.vscode-html-css' v0.2.3...
(node:336) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Extension 'ecmel.vscode-html-css' v0.2.3 was successfully installed.

I have verified that the warning does NOT occur in version 1.36.0 in which similar issue #67534 was fixed.

VS Code version: Code 1.39.0 (9df03c6d6ce97c6645c5846f6dfa2a6a7d276515, 2019-10-09T06:58:04.439Z) OS version: Windows_NT x64 10.0.19500

System Info

Item	Value
CPUs	Intel® Xeon® CPU E5-1650 v3 @ 3.50GHz (12 x 3492)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_deferred_display_list: disabled_off skia_renderer: disabled_off surface_synchronization: enabled_on video_decode: enabled viz_display_compositor: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	15.91GB (7.99GB free)
Process Argv	–folder-uri file:///d%3A/code/devcanvas/client/VSCodeExtension
Screen Reader	no
VM	0%

Extensions (5)

Extension	Author (truncated)	Version
vscode-html-css	ecm	0.2.3
devinsights	Mic	2019.10.11-1
cpptools	ms-	0.25.1
vscode-typescript-tslint-plugin	ms-	1.2.2
debugger-for-chrome	msj	4.12.0

[alanaudi]

@Matthew-Cherry87 @Space7Panda

It seems that just exporting one of --no-deprecation, --no-warnings, and --throw-deprecation could mute the annoying deprecation warning now.

Here is my installation script

export NODE_OPTIONS="--no-deprecation" && cat path-to-extension-list | xargs -L 1 code --install-extension

Installing extensions...
Installing extension 'casualjim.gotemplate'...
Extension 'casualjim.gotemplate' v0.4.0 was successfully installed.

[Matthew-Cherry87]

@jdstraye AFAIK the deprecation warning is only a warning, and only appears when installing using the CLI or when developing extensions. I wouldn’t expect any extension to fail because of it. More likely the latest versions of some extension won’t install on your older VS Code version.

Sure, but what if you’re in an enterprise environment and want to push out Visual Studio Code + XYZ extensions to 100s or 1000s of workstations and regularly update said extensions.

From memory, the warning output also pauses the installation of extensions until the user inputs any key into the console window…

All I want is the ability to install extensions via CLI without errors/warnings/additional console windows popping up.

That’s hardly an unreasonable request.