Chrome shows prompt dialog for "Restore Pages" after every debugging session.

Describe the bug

After a normal debugging session, launching another debugging session always shows “Restore Pages? Chrome did not shutdown correctly.”

To Reproduce Steps to reproduce the behavior:

1. Opened the following project in vs code via; “Remote-Containers: Open repository in container” https://github.com/akutruff/conway-life-react-redux

In container terminal:

cd app
yarn install
yarn start

1. Run debugger. Close page either via “x” on chrome or stopping in the debugger.

2. Reopen chrome.

Log File vscode-debugadapter-1.json.gz

VS Code Version: 1.48.2

Additional context I have tried setting up a separate debug profile. Other people experiencing this problem used to use a command line flag that Chrome has since removed. This has been tried:

{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
        {
            "type": "chrome",
            "request": "launch",
            "name": "Launch Chrome against localhost",
            "url": "http://localhost:3000",
            "webRoot": "${workspaceFolder}",
            "userDataDir": false,
            "runtimeArgs": [
                "--profile-directory=debug-profile",
                "--noerrors", "--disable-session-crashed-bubble", "--disable-infobars"
              ],
            "trace": true
        }
    ]
}

[pcjmfranken]

I was encountering this issue today with VSCode 1.52.1 and Debugger for Chrome extension 4.12.11.

Adding "browserLaunchLocation": "ui" to the launch config seems to have fixed the “restore pages” issue for me. It does take a few seconds to start up the browser with this setting though.

This issue has only ever occurred for me when launching Chrome through a debug launch config. I have never had the restore pages popup when launching a Chrome debug window through the commandline. It also seemed to happen more often after having stopped the previous Chrome debug session through the VSCode UI stop button (or shift+f5), rather than quitting Chrome through the application menubar.

Current config (relevant parts):

    {
      "name": "Launch Chrome",
      "type": "pwa-chrome",
      "request": "launch",
      "browserLaunchLocation": "ui",
      "url": "http://localhost:3000",
      "userDataDir": "${workspaceFolder}/.vscode/debug-profile-chrome",
      "webRoot": "${workspaceFolder}",
      "skipFiles": ["<node_internals>/**"]
    }

Probably unrelated but who knows: That same UI stop button also seems to gracelessly kill node processes that were launched from a launch config, sometimes resulting the following session to fail with a segfault error.

Quiting through the VSCode UI: zsh: killed /usr/bin/env [userdir]/.nvm/versions/node/v14.15.4/bin/node --inspect Quiting by doing a ctrl+c in the terminal: Waiting for the debugger to disconnect...

[navels]

I was encountering this issue today with VSCode 1.52.1 and Debugger for Chrome extension 4.12.11.

Adding "browserLaunchLocation": "ui" to the launch config seems to have fixed the “restore pages” issue for me. It does take a few seconds to start up the browser with this setting though.

You are my hero