question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Closing a notebook marked as trusted shouldn't trigger the save modal

See original GitHub issue

OS: macOS Catalina (10.15.5) Extension version: 2020.7.93499-rc

Steps to reproduce

  1. Create an untrusted notebook
  2. Open it in VS Code and click “Trust” when prompted
  3. Close the notebook

Expected behaviour

I expect the preference to be saved in VS Code’s storage, similar to the pythonPath work (#11015). There is also no * next to the notebook’s name indicating that it was modified.

Actual behaviour

Closing the newly trusted notebook triggers a “Save or discard changes” modal, and discarding changes doesn’t save the trusted state for the next time the notebook gets reopened:

trust_save

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
kimadelinecommented, Jul 10, 2020

Still happening when using 2020.8.93521-dev:

trusted_save

0reactions
IanMatthewHuffcommented, Jul 14, 2020

Validated. Trusting a notebook doesn’t look to trigger a save change anymore.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Close and reopen notebooks in OneNote - Microsoft Support
OneNote for Windows 10 · Click or tap the Show Notebook List button Show Notebooks button · Right-click the name of the notebook...
Read more >
Emergency Operations Center Quick Reference Guide - FEMA
Having a coordination structure such as an Emergency Operations Center (EOC), from which leaders can coordinate and direct emergency efforts, is essential ...
Read more >
Get predictions from a custom trained model | Vertex AI
This page shows you how to get online (real-time) predictions and batch predictions from your custom trained models using the Google Cloud console...
Read more >
Language Server Protocol Specification - 3.17
This is done to keep the save fast and reliable. If a server has registered for open / close events clients should ensure...
Read more >
User and Workspace Settings - Visual Studio Code
For example, @tag:workspaceTrust for settings related to Workspace Trust, ... file must not be saved after delay, and the editor must not be...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found