Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove the words `Save` from save icon in interactive window

See original GitHub issue

Save icon is universal, not sure it needs a lable save. We don’t have the label for the export icon, Screen Shot 2021-07-11 at 16 53 17

Issue Analytics

State:
Created 2 years ago
Reactions:2
Comments:9 (9 by maintainers)

Top GitHub Comments

1reaction

rebornixcommented, Jul 12, 2021

Seems weird, as none of the icons in standard editor toolbar (today in VSCode) display text when we have icons.

@DonJayamanne actions on editor toolbar are meant to be secondary since the primary actions for the text editor are typing, auto-complete, code navigation, etc, which are all accessible through keyboard and even keyboard centric. However notebook is relatively new and users are not necessarily familiar with the shortcuts or icons of the primary actions, so the labels are majorly for educating users. We don’t have such ux before (an in-editor toolbar) so we are still exploring and I’m not sure I’ll be 100% satisfied with icons only.

1reaction

rebornixcommented, Jul 12, 2021

My 2 cents:

It makes sense to have Export action on the toolbar, but not Save. The Interactive is not file based so there is no “save” (just like no dirty indicator)
Whether the label for the actions should be visible to users is going to be controlled by the core based on conditions (e.g. width, settings), other than controlled by each command.