Updating the plotly.js version used in the plotly mimetype renderer

Hi, plotly.py maintainer here. First off, thanks for supporting the plotly mimetype. This makes vscode-python a really nice environment for plotly.py users.

I’m working on a refactor/generalization of the plotly.py rendering subsystem (See https://github.com/plotly/plotly.py/pull/1474) and one of the things I’d like to do is automatically apply a dark theme (https://medium.com/@plotlygraphs/introducing-plotly-py-theming-b644109ac9c7) when plotly.py detects that it’s running in vscode. For this to work, the plotly.js version used in the vscode-python mimetype renderer would need to be updated so that it includes theme support.

I’d be happy to submit a PR for this if someone could point me to where the mimetype renderer is maintained (I didn’t find it when searching this repo).

As a side question, do you have a recommendation for the best way to detect that a Python session is running in VSCode? Right now I’m looking for the presence of the VSCODE_PID environment variable.

Thanks! 🙇

Environment data

• VS Code version: Version 1.32.3 (1.32.3)
• Extension version (available under the Extensions sidebar): 2019.3.6139

[rchiodo]

Do you have any established processes for dependency updates like this? I’m happy to submit a PR with just the package.json/package-lock.json updates, but let me know if there’s anything else that would make things easier on your end.

Submitting a PR would be the quickest/easiest I think. Our CI system for the PR should verify that the update works.

[captainsafia]

@jonmmease Thanks for following up on the other thread! I’ve merged and released the bump to @nteract/plotly. Moving forward, updates will be released on a weekly cadence alongside updates in the nteract monorepo. I hope this unblocks your work here.