Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`keytar` brings in a lot of files in the build

See original GitHub issue

I’m looking into reducing the number of files in our server build.

Turns out that keytar brings in a lot of file because the use of prebuild-install in the install script. Because of that prebuild-install is a dependency (not just a dev dependency) and prebuild-install and all it’s dependencies end up in the bits we ship (tar-fs, tar-stream, readable-stream…).

It’s not easy to remove all these unnecessary from the build. We have a hand curated filter (https://github.com/microsoft/vscode/blob/main/build/.moduleignore) but that’s cumbersome and might change after an update.

Issue Analytics

State:
Created 2 years ago
Comments:10 (10 by maintainers)

Top GitHub Comments

1reaction

TylerLeonhardtcommented, Jun 23, 2022

@thegecko that comes from here: https://github.com/microsoft/vscode/blob/3268d1d47d1ae902bc1ec45bd2153fdacab66ff6/src/vs/workbench/api/common/extHostRequireInterceptor.ts#L36

It’s really just keytar, the vscode module itself, obviously, and the open/opn module.

Keytar behaves this way so that you have consistency if your extension is actually running on a remote. You get the value stored on the client side (the side with an actual keychain).

1reaction

TylerLeonhardtcommented, Mar 12, 2022

@deepak1556 do you think we could meet and go over the approach with vscode-node-sqlite3 and how I could do the same for keytar? I like the idea of following that pattern and I’m curious to know how we publish vscode-node-sqlite3