Handle non-existent NODE_PATH directory in Files.resolve

If nodePath refers to a non-existent directory, the following occurs:

events.js:167
      throw er; // Unhandled 'error' event
      ^

Error: spawn C:\Users\{user}\AppData\Local\Programs\Microsoft VS Code\Code.exe ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:229:19)
    at onErrorNT (internal/child_process.js:406:16)
    at process._tickCallback (internal/process/next_tick.js:63:19)
Emitted 'error' event at:
    at Process.ChildProcess._handle.onexit (internal/child_process.js:235:12)
    at onErrorNT (internal/child_process.js:406:16)
    at process._tickCallback (internal/process/next_tick.js:63:19)

@egamma handled this in the deprecated vscode-tslint extension with this change, and I followed suit in my extension.

However, since fs.exists is deprecated, and existence checks in general are not recommended, I was wondering if it was possible for this to be handled by vscode-languageserver-node instead?

I see that you’re using on('error') in addition to a try/catch block – is this just a bug in Electron or Node.js? If so, is there an issue tracking it?

[dbaeumer]

@glen-84 please ping if you have any additional info.

[dbaeumer]

I will keep it open and see if you find something out. May be we can improve the behaviour in the library as well.