question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Insert replace adoption is painful

See original GitHub issue

Testing https://github.com/microsoft/vscode/issues/93754

I tried to adopt 6.2.0-next.1 in the JSON language server and it turned out to be quite painful

  • CompletionItem is no longer compatible to the previous version as the type of textEdit has changed
  • (a) Passing a CompletionItem to resolveCompletionItem of the old, not-yet adopted version of the JSON language service doesn’t compile
  • (b) If I update the json-language-service with the new API, I break old, not-yet adopted users.

Ideally the change would be a new optional property. I would suggest CompletionItem.insertReplaceTextEdit

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:1
  • Comments:8 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
dbaeumercommented, Oct 12, 2020

Thanks!! I changed the diagnostic code though to make it non breaking

0reactions
aeschlicommented, Oct 12, 2020

In the meantime I adopted all my language services (I had no choice).

Read more comments on GitHub >

github_iconTop Results From Across the Web

11 IUD Replacement FAQs: Pain, Side Effects, Aftercare, More
There's a good chance IUD replacement won't be as bad as you might be thinking. It takes mere minutes, so any discomfort should...
Read more >
Why Is Adjustment So Hard after Placement? - Adoption.org
Most people do not handle change well simply because most changes are not easy, and, generally, the easy path is the preferred path....
Read more >
“Adoption is Not the Same as Having a Child of Your Own”
It is true. Children should not be ripped out of their biological parents' working class arms as a substitute for 'real' children we...
Read more >
Getting your second IUD might not be as painful as ... - Insider
During any IUD insertion, Dr. Sherry said that faulty IUD placement is the most common reason for extreme pain and discomfort during and...
Read more >
Adoption Moved to Facebook and a War Began | WIRED
People who adopt children, often from overseas, and then change their minds find new homes for them in Facebook “adoption disruption” groups, ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found