Support allCommitCharacters even if the client announces commit characters per item.

'm using the client library here for LSP support in a VS Code extension. My server is sending a dynamic registration that includes commit characters like this:

{
	"id": "3",
	"method": "textDocument/completion",
	"registerOptions": {
		"documentSelector": [
			{
				"language": "dart",
				"scheme": "file"
			}
		],
		"triggerCharacters": [
			".",
			"=",
			"(",
			"$"
		],
		"allCommitCharacters": [
			".",
			"("
		],
		"resolveProvider": true
	}
},

However pressing the commit characters doesn’t seem to have any effect. It’s enabled in VS Code and it works as expected for TypeScript. Is there anything else I need to do?

[DanTup]

btw, in the spec it has this:

	 * If a server provides both `allCommitCharacters` and commit characters on an individual
	 * completion item the ones on the completion item win.

This reads like it’s reasonable to provide both, and that the client would fall back to allCommitCharacters if it’s not set on the completion (otherwise it wouldn’t really make sense to send both).

[dbaeumer]

Technically there is nothing that prevents us from implementing it. It is simply not done.