Live Share guest session flow with restricted workspaces
See original GitHub issueVersion: 1.57.0-insider (user setup) Commit: 4f3d865a6b46a4ead49cf83fe1c30d95d0a34220 Date: 2021-05-31T05:14:38.041Z
Start a Collaboration Session on another computer On your machine have Live Share installed and try to join the session.
a open an new empty window.
b Live share Join Session
can not be found as it requires workspace trust.
c. Trust the empty workspace. The Join Session
is still not available as Live Share is still disabled, no explanation
d. reload the window makes the window untrusted again (also reported in https://github.com/microsoft/vscode/issues/124824)
e. open a trusted window to get the Live Share commands
f. Join the session
g. new window opens, with root rendered red.
- The banner is very subtle here. It took me while to understand why the root node in the explorer is red
- I’m forced to trust the workspace
Looks like Live Share has not yet adopted the untrustedWorkspaces
capability.
Issue Analytics
- State:
- Created 2 years ago
- Comments:6 (4 by maintainers)
Top GitHub Comments
c
is a bug. If you have trusted the empty window, the empty window should transition fromrestricted mode
to atrusted window
and all extensions should be enabled.d
is expected since the trust state is for the session, and not for all empty windows. We are considering making it easier to trust all empty windows.We are starting supporting PDF files preview through Live Share sessions because the filesystem provided by Live Share v1.0.5196 supports binary files.
It works though some tweaks still needed on Live Share’s side.
My main concern is that it is difficult for users to find how to enable LaTeX Workshop on the guest’s side. Users have to trust the workspace. However, the dialog to ask users to trust it doesn’t pop up when joining the session on the guest’s side.