Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Notebook theme colors review

See original GitHub issue

After we introduced more customizations of the notebook layout, the theme colors for notebook don’t cover all the scenarios, we should review and consolidate them to ensure they work for all combinations of settings.

List of existing theme colors:

"notebook.cellEditorBackground"
"notebook.cellToolbarSeparator"
"notebook.focusedEditorBorder"
"notebook.outputContainerBackgroundColor"
"notebook.cellBorderColor"
"notebook.cellInsertionIndicator"
"notebook.cellStatusBarItemHoverBackground"
"notebook.focusedCellBorder"
"notebook.inactiveFocusedCellBorder"
"notebook.selectedCellBackground"
"notebook.selectedCellBorder"
"notebook.symbolHighlightBackground"
"notebookScrollbarSlider.activeBackground"
"notebookScrollbarSlider.background"
"notebookScrollbarSlider.hoverBackground"
"notebookStatusErrorIcon.foreground"
"notebookStatusRunningIcon.foreground"
"notebookStatusSuccessIcon.foreground"
~"notebook.focusedRowBorder"~
~"notebook.rowHoverBackground"~

Questions/confusion/requirements

notebook.cellBorderColor is applied for output background by default #125459
Support output border color #125462
notebook.cellToolbarSeparator should be a generic toolbar vertical separator color
naming convention (notebook.status.*, notebook.scrollbarslider.* ?)

Issue Analytics

State:
Created 2 years ago
Reactions:2
Comments:15 (10 by maintainers)

Top GitHub Comments

2reactions

miguelsoloriocommented, Jun 9, 2021

For output background color, I’ve actually made it transparent ("notebook.outputContainerBackgroundColor": "#0000") in my user settings which tends to look a little better with charts + tables: