Notebooks inserts/edits code cell

https://dev.azure.com/monacotools/Monaco/_build/results?buildId=147845&view=logs&j=306b2268-2a17-5e97-ab97-f41a26dc5206&t=f99521cb-b554-56f1-45de-e2bc176b0ad3&l=72

  1) VSCode Smoke Tests (Electron)
       Notebooks
         inserts/edits code cell:
     Error: Timeout: get element '.quick-input-widget' after 20 seconds.
      at poll (D:\a\1\s\test\automation\out\code.js:65:19)
      at async Code.waitForElement (D:\a\1\s\test\automation\out\code.js:184:16)
      at async QuickInput.waitForQuickInputClosed (D:\a\1\s\test\automation\out\quickinput.js:32:9)
      at async QuickInput.selectQuickInputElement (D:\a\1\s\test\automation\out\quickinput.js:41:13)
      at async QuickAccess.runCommand (D:\a\1\s\test\automation\out\quickaccess.js:146:9)
      at async Notebook.openNotebook (D:\a\1\s\test\automation\out\notebook.js:15:9)
      at async Context.<anonymous> (out\areas\notebook\notebook.test.js:26:13)

Screenshot reveals that the command cannot be found? Is there a missing extension activation?

[roblourens]

Good catch with the fact that the command might only come in later, I thought we had something to wait on extensions load, but maybe not for smoke tests…

I thought that too but apparently not.

Got one PR to add a .ipynb to the smoketest repo: https://github.com/microsoft/vscode-smoketest-express/pull/11 I tested that it doesn’t break the search tests or any others.

And another to enable tests and delete the extension (gotta fix the repo url, I’m watching the CI https://github.com/microsoft/vscode/pull/159521))

[roblourens]

Broke in the real build because I only added the build step under the OSS quality…